feat(sso): add entityId to configureSAMLByMetadata settings#739
Merged
Conversation
Add the optional entityId field to SSOSAMLByMetadataSettings so callers can persist the IdP entity ID alongside a metadata URL. This lets IdP-initiated SAML login resolve the tenant by the SAML response issuer. Backend: descope/backend#1280 Related issue: descope/etc#16175 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Adds an optional entityId field to SSOSAMLByMetadataSettings so configureSAMLByMetadata can persist the IdP entity ID for issuer-based tenant resolution on IdP-initiated login.
No issues found — good bones! The settings object passes straight through to the request body, the field is optional (consistent with the metadata flow), and the test asserts it round-trips. Woof!
aviadl
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/16175
Description
Adds an optional
entityIdfield toSSOSAMLByMetadataSettings, so callers ofmanagement.sso.configureSAMLByMetadatacan persist the IdP entity ID alongside a metadata URL.This lets IdP-initiated SAML login resolve the tenant by the SAML response issuer. Without it, metadata-configured tenants had no stored entity ID and the issuer lookup failed (reported by Navan during SSO migration).
Backend PR: descope/backend#1280
Must