feat(text): stabilize truncate() - #7295
Open
tomas-zijdemans wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7295 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 617 618 +1
Lines 51637 51641 +4
Branches 9359 9359
==========================================
+ Hits 49075 49078 +3
Misses 2021 2021
- Partials 541 542 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
truncate()to stable after five months unstable with zero bug reports. The new specifier is@std/text/truncateand it's now exported frommod.ts.The diff is a rename plus bookkeeping:
unstable_truncate.tstotruncate.ts(test file too),@experimentaltag dropped, JSDoc import specifiers updated,deno.jsonexport swapped. No logic changed. Behavior is identical to what's been on JSR since March (#7052).One open question from the original request (#6456) is word and grapheme-aware truncation, which this API doesn't do. That's not a blocker: it lands later as an additive
boundaryoption defaulting to today's behavior. What stabilization freezes is the defaults, so those are what to review hardest: UTF-16 code-unit measurement (matches every JS string builtin), no whitespace trimming before the suffix, and…as the default suffix.Tested: 19 unit tests and 4 doc examples pass, lint and fmt green.