Repository navigation
perf: build declaration inlays from model facts - #3
Merged
Merged
Conversation
Record authored type syntax through decoding and cloning. Reuse the snapshot's authored subjects and typed-data index without composing source or populating grammar for inlays. Preserve fragment and YAML-alias source boundaries. A/B vs bb6941f, three rounds/best of three: inlays/unwrap time -27.4% (4.9% noise), peak -34.8%, kept -30.2%. Mixed times stay within noise; snapshot-first peak +10.0%, kept +0.1%, accepted as construction-order overlap. Source-first peak/kept +0.1%. large/service time stays within 13.0% noise, peak +0.4%, kept +0.6%. Gate: Ruff, format, strict mypy, 5861 passed/68 skipped/1 xfailed. Focused pure-Python YAML: 305 passed. Inlay and both mixed linearity checks pass. Record the acceptance decision, workload boundaries, raw phase evidence and allocation attribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
A/B against bb6941f, three alternating rounds/best of three: cold inlays are 27.4% faster (4.9% noise), with 34.8% lower peak and 30.2% lower retained allocation. Routine rebuild and both mixed sequence times stay within measured noise.
Snapshot-first mixed peak increases 10.0% (about 3.07 MB), with retained allocation +0.1%, an accepted construction-order overlap. Source-first peak and retained allocation are +0.1%. This is traced peak with the collector paused, not a 10% steady-memory claim.
Full report: docs/reports/2026-10-10/service-model-inlays.md.
Verification