Conversation
Signed-off-by: Jin, Youzhi <youzhi.jin@intel.com>
delock
self-requested a review
September 22, 2026 02:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #8381 @delock
fix
This pull request refactors device handling in the activation checkpointing code to simplify and standardize how device variables are used. The main change is to consistently use a
devicevariable instead ofcuda_deviceand to remove unused or redundant stream-related code. This improves code clarity and maintainability without changing functionality.Device handling simplification:
cuda_devicewith a unifieddevicevariable obtained fromget_accelerator().current_device_name()incheckpointing.py. [1] [2] [3]copy_to_device,gather_partitioned_activations, andmove_to_deviceto use the newdevicevariable. [1] [2] [3] [4]Stream and code cleanup:
transport_streamvariable, and deleted commented-out or unused stream synchronization code.These changes make the device management more straightforward and reduce potential confusion around device and stream handling in activation checkpointing.