Skip fp16 ZeroPP tests on accelerators without fp16 support - #8610
Merged
Merged
Conversation
jinyouzhi
requested review from
loadams,
tjruwase and
tohtana
as code owners
September 20, 2026 15:42
Signed-off-by: Jin, Youzhi <youzhi.jin@intel.com>
Signed-off-by: Jin, Youzhi <youzhi.jin@intel.com>
delock
self-requested a review
September 22, 2026 02:48
delock
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #8381 @delock
Fix zeropp 9 (sequential) in #8381 (comment)
passed in https://github.com/deepspeedai/DeepSpeed/actions/runs/35571162595/job/106242965025
This pull request updates the
tests/unit/runtime/zero/test_zeropp.pytest suite to ensure that certain tests are only run on accelerators that support FP16 precision. This prevents test failures on hardware that does not support FP16.Test robustness improvements:
@pytest.mark.skipifdecorators to thetest,test_eval, andtest_gradient_accumulationmethods inTestZeroPPConfigSweepand atestmethod in another test class, so these tests are skipped if the accelerator does not support FP16. This usesget_accelerator().is_fp16_supported()to check hardware capability. [1] [2] [3] [4]get_acceleratorfromdeepspeed.acceleratorto enable the FP16 support check.