Skip to content

test: adopt MockChatGenerator in tests#11994

Merged
anakin87 merged 5 commits into
mainfrom
use-mock-chat-generator
Jul 14, 2026
Merged

test: adopt MockChatGenerator in tests#11994
anakin87 merged 5 commits into
mainfrom
use-mock-chat-generator

Conversation

@anakin87

@anakin87 anakin87 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Proposed Changes:

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jul 14, 2026 8:24am

Request Review

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@anakin87
anakin87 marked this pull request as ready for review July 13, 2026 15:56
@anakin87
anakin87 requested a review from a team as a code owner July 13, 2026 15:56
@anakin87
anakin87 requested review from davidsbatista and removed request for a team July 13, 2026 15:56
@anakin87 anakin87 self-assigned this Jul 13, 2026

@davidsbatista davidsbatista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@anakin87
anakin87 merged commit af7ec4a into main Jul 14, 2026
22 checks passed
@anakin87
anakin87 deleted the use-mock-chat-generator branch July 14, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants