fix(abacus-plot): fix reshape parameter and PDOS plotting issues#7455
Merged
Merged
Conversation
- Remove invalid 'newshape' keyword from np.reshape() call - Remove unnecessary reassignment of dosplot.ax after _plot() calls Fixes deepmodeling#6864
mohanchen
added
Bugs
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #6864
Unit Tests and/or Case Tests for my changes
No additional tests required. These are simple Python code fixes.
What's changed?
np.reshape()call inPDOS._read()method: remove invalidnewshapekeyword argument that causes TypeError in newer numpy versions_parial_plot()method: remove unnecessary reassignment ofdosplot.axafter_plot()calls, which caused AttributeError whendosplot.axwas incorrectly assignedAny changes of core modules? (ignore if not applicable)
No changes to core modules. The modifications are only in the
tools/plot-tools/abacus_plot/dos.pyPython script.