You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The repair command's failure is discarded even though the following package installs depend on a consistent dpkg state. If an interrupted transaction cannot be configured, continuing only defers the failure (or leaves the host partially configured); let errexit stop setup at the repair failure.
The reason will be displayed to describe this comment to others. Learn more.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Each matrix row invokes the reusable setup independently, and that setup checks out github.ref_name and runs git pull before restaging the remote compose file. Since this release can run for roughly 28 hours, a branch update during the run can make later passes use a different repository configuration while all results still accumulate in one set. Pin the remote checkout to the workflow's immutable github.sha for every row.
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
Per-row reporting causes repeated publication side effects and leaves the release summary representing only one pass.
Review effort: Balanced Findings: None
Previously missed (3)
In code that hasn't changed since last review
Generate the summary from accumulated results after all passes
.github/matrix/release.sh:38
These independent one-iteration rows do not produce a seven-pass summary. Every reusable-workflow setup calls build-benchmark-artifact-remote.sh, which deletes run/results before reusing the cached JAR; consequently each row generates release-benchmark-summary.svg from only its own pass, and each upload overwrites the shared set/actor summary with that single-pass SVG. Generate and upload the summary once from the accumulated set after all passes, while retaining the per-row raw-result uploads.
Avoid repeating notifications and NFS sync for each matrix row
Each of the seven matrix rows invokes the reusable workflow's complete report phase, which posts a Slack notification and performs a full bucket-to-NFS sync. A single release will therefore emit seven notifications and seven expensive syncs, including reports over intermediate 1–6-pass data. Keep the failure-tolerant per-row GCloud upload, but move notification and NFS synchronization to one post-matrix job (or gate those side effects with a separate input).
Use standard “GitHub” capitalization
.github/scripts/run-ssh-local.sh:44
Use the product's standard capitalization: “GitHub”.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.