Repository navigation
Address remaining README review feedback - #2
Merged
elijahpetty merged 1 commit intoSep 28, 2026
Merged
elijahpetty merged 1 commit into
elijahpetty merged 1 commit into
Conversation
- Fix duplicated `server = server =` assignment in root README snippets - Rename my_dh_cli entry function `app` to `main` to match my_dh_toolkit - Explain deferred deephaven imports in my_dh_cli (code comment + README) - Split the long my_dh_toolkit __init__.py explanation into short bullets - Remove redundant toolkit summary under the pattern table - Note that toolkit's queries.py/utils.py are deliberate copies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1, targeting the
add-examplebranch. Addresses the remaining README-related review feedback from @chipkent (does not touchsetuptools-deployment.md, which is moving to the core docs PR).server = server = Server(...)assignment in the root README (two places). Keeps the two-lineserver = Server(...)/server.start()form rather thanserver = Server(...).start(), becauseServer.start()returnsNone— the two-line form already holds a reference, so the server isn't garbage collected.my_dh_clicommand functionapp→mainto matchmy_dh_toolkit(cli.py,__main__.py,pyproject.toml, READMEs, and the "Adapt an example" snippet).my_dh_cli/cli.pynow has the same comment as the toolkit explaining whydeephavenis imported inside the function; Example 2's "What to study" notes it too.__init__.pyexplanation in Example 3 into short bullets.queries.py/utils.pyare deliberate copies ofmy_dh_libraryso each example stays self-contained.Verified the renamed
my_dh_cli.cli:mainentry point resolves andpython -m my_dh_cli --helpruns; not run end-to-end against a live Deephaven server.🤖 Generated with Claude Code