Add extra domains for helm_lib_envs_for_proxy #192
Open
Conversation
BrazenFox
force-pushed
the
add-custom-no-proxy
branch
from
dc30c88 to
338cc94
Compare
trublast
force-pushed
the
add-custom-no-proxy
branch
2 times, most recently
from
411e87c to
6a9fa9d
Compare
trublast
force-pushed
the
add-custom-no-proxy
branch
3 times, most recently
from
07e61b2 to
dcd1645
Compare
… to exclude proxying Signed-off-by: Maksim Kiselev <maksim.kiselev@flant.com>
trublast
force-pushed
the
add-custom-no-proxy
branch
from
dcd1645 to
b6d6a10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the ability to helm_lib_envs_for_proxy to add extra domains
Why do we need it, and what problem does it solve?
The subnets podSubnetCIDR, serviceSubnetCIDR and the clusterDomain domain are added to NoProxy automatically. But stronghold and secrets-stora-integration go by the “short name of the service", because it is in this name that the certificate is issued. It's made for that. in order not to recreate the certificate when changing clusterDomain.
This ability allow to add custom services for include in noproxy list