Harden the RFQ venue: maker approval and quote cancellation#24
Merged
Conversation
0xMuang
added a commit
that referenced
this pull request
Jul 14, 2026
Record the RFQ backend as a TypeScript SDK and local-reference path before MVP demo backend work begins, while preserving pending PR context for RFQ hardening, E2E, CLI, and BUIDL fixtures. Constraint: Open PRs #24, #28, #29, #30, and #35 already cover parts of RFQ hardening, protected-router scenarios, live demo, CLI, and BUIDL-like fixtures. Rejected: Treating an RFQ backend as a Corner Store-operated production server | would blur operator responsibilities for pricing, signer custody, inventory, hosting, and compliance prechecks. Confidence: high Scope-risk: narrow Directive: Implement RFQ SDK interfaces first; any MVP backend must reuse merged E2E/CLI/BUIDL paths instead of creating parallel demo infrastructure. Tested: git diff --check Not-tested: services/rfq implementation or runtime tests; documentation-only change
Resolve the stacked PR branch after main advanced with the router venue binding fix, Phase 1 architecture baseline, and RFQ backend SDK documentation/code. Constraint: PR #24 must merge after #23 and before the higher stacked PRs. Rejected: Dropping either RFQ-002 or RFQ-SDK documentation state | both are accepted completed work on main/stack. Confidence: high Scope-risk: moderate Directive: Continue stacked PR merges in order after #24 lands: #25, #26, #27, #28, #29, #30. Tested: git diff --cached --check; scripts/check.sh Not-tested: GitHub CI after push
0xMuang
added a commit
that referenced
this pull request
Jul 14, 2026
Resolve the stacked PR branch after main advanced with RFQ hardening, Phase 1 architecture baseline, and RFQ SDK work. Constraint: PR #25 must land after #24 and before the higher stacked manifest/E2E/CLI PRs. Rejected: Keeping duplicate D008 decision numbering | would make the decision log ambiguous after merging RFQ-002 and CMP-001. Confidence: high Scope-risk: moderate Directive: Continue stacked PR merges in order after #25 lands: #26, #27, #28, #29, #30. Tested: git diff --cached --check Not-tested: full local scripts/check.sh for this conflict-only reconciliation; rely on GitHub CI after push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFQ v2 hardening (RFQ-002), stacked on #23.
setMakerApproved(onlyOperator), settlement rejects unapproved makers (RFQMakerNotApproved)cancelQuoteNonce/cancelQuoteNonces, idempotent, reuses theusedQuoteNoncefill guarddocs/rfq-threat-model.md+ FEATURES/PROGRESS/security.md bookkeepingTests:
forge test --offline133/133 (9 new RFQAdapter tests),services/rfqsmoke ok. EIP-712 surface unchanged (offchain signer compatible).Deferred: router-path integration scenarios (tracked in PROGRESS Next).