feat(resource_redshift_database): basic zeroetl support#43
feat(resource_redshift_database): basic zeroetl support#43Intuinewin wants to merge 4 commits intodbsystel:masterfrom
Conversation
|
Thank you for your contribution. Again, sorry for the late feedback. The PR looks good so far but an integration/acceptance test is missing. Please provide one simple parameterized test that can be used to test a zeroetl database integration. |
|
I asked Claude to address the review feedback because this feature is also potentially useful to us. Here are the commits we came up with:
|
…ith on datashare_source and zeroetl_integration ExactlyOneOf required one of the two blocks to always be set, which prevented creating a plain local database. ConflictsWith allows both to be absent while still preventing them from being set simultaneously. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cceptance test Validates that setting both zeroetl_integration and datashare_source in the same resource configuration produces a plan-time error. This test runs without any real AWS infrastructure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Creates a database from a zero ETL integration and verifies the integration_id attribute is preserved across plan/apply cycles. Requires REDSHIFT_ZERO_ETL_INTEGRATION_ID to be set; skipped otherwise. The target Redshift cluster must be ra3.xlplus or larger, as smaller node types do not support zero ETL integrations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a3da7df to
e7a80f6
Compare
|
Thanks @alexjurkiewicz , I cherry-picked your commits except 12844ad as I don't think it's necessary |
SmallPR which enables zeroetl support for the database resource
Unfortunately, I haven't found a way to query on the cluster if a db is associated with an integration
Ref: https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_DATABASE.html