dbeaver/pro#10614 Add project sharing API - #3
Conversation
…nfiguration-ofproject-share # Conflicts: # apis/pom.xml
…beaver/pro#10614-Configuration-project-share-2
There was a problem hiding this comment.
🟡 Changes recommended
The newly introduced API models have identifier/timestamp typing and naming choices that are ambiguous/inconsistent with existing project-sharing models and should be corrected before publishing the API.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds new public API model types to support project sharing operations in the DataDam Share API module, aligning with the “Add project sharing API” effort.
Changes:
- Introduces request DTOs for creating/updating shared projects and pushing project configuration.
- Adds project activity model + activity type enum for tracking push/pull operations.
File summaries
| File | Description |
|---|---|
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDUpdateProjectRequest.java | Adds DTO for updating shared project metadata (name/description). |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDPushProjectConfigurationRequest.java | Adds DTO for pushing shared project configuration with optimistic concurrency via fingerprint. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDProjectActivityType.java | Defines push/pull activity type enum. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDProjectActivity.java | Adds activity model for audit/history-like entries. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDCreateProjectRequest.java | Adds DTO for creating a shared project. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@codex review |
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
No description provided.