Fix pathname completions not descending into directories - #2211
Merged
Conversation
Make pathname completions as for _eg_ /source much better * fix a bug in which completions would complete a directory, but not then generate candidates on files from within that directory * fix a bug in which completions were not generated if the pathname started with "~/" or "/". Limitations and future work: this is perfect for the usecase of /source, but other usecases such as /tee and /once should not be limited to completing on pathnames ending with ".sql".
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make pathname completions as for eg
/sourcemuch better~/or/.Limitations and future work: this is perfect for the usecase of
/source, but other usecases such as/teeand/onceshould not be limited to completing on pathnames ending with.sql.Example which previously did not show completions:
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).