fix(test): wait for CA Certificate Ready before reading its secret#180
Open
drewr wants to merge 1 commit into
Open
fix(test): wait for CA Certificate Ready before reading its secret#180drewr wants to merge 1 commit into
drewr wants to merge 1 commit into
Conversation
The gateway-accepted chainsaw test creates a cert-manager Certificate and immediately runs a script that reads the secret cert-manager is supposed to produce. With no wait between the two, the script can run before cert-manager has issued the secret, producing: Error from server (NotFound): secrets "..." not found error: no objects passed to apply Asserting Certificate.status.conditions[Ready]=True between the Certificate create and the secret-copy script gates everything that depends on the issued secret, including the CA ClusterIssuer. Example failure: https://github.com/datum-cloud/network-services-operator/actions/runs/27240379708/job/80442454016 (surfaced in PR #179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gateway-acceptedchainsaw test creates a cert-managerCertificateand immediately runs a script that reads the secret cert-manager is supposed to produce. There's no wait between the two, so the script can race ahead of the issuance and fail with:Asserting
Certificate.status.conditions[Ready]=Truebetween theCertificatecreate and the secret-copy script gates everything that depends on the issued secret, including the CAClusterIssuerthat follows.Example failure: https://github.com/datum-cloud/network-services-operator/actions/runs/27240379708/job/80442454016 (surfaced in #179, which makes no test-relevant code changes)