fix(nix): push hash update directly to triggering branch#77
Merged
Conversation
Drop peter-evans/create-pull-request in favour of a direct git push back to the branch that triggered the workflow. The go.mod change always arrives on a feature/Renovate branch, not main, so a direct push is not blocked by repo rules and keeps the dep update and hash fix in the same branch.
ecv
approved these changes
Jun 2, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Seems fine but is there an Issue somewhere describing what this is trying to accomplish?
Contributor
Author
|
Right question! Originally datum-cloud/datumctl#199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up on #75 — the original PR used
peter-evans/create-pull-requestwhich opened a separate PR targetingmain. That's wrong:go.modshould never change directly onmain, so the workflow will always be triggered from a feature or Renovate branch where a directgit pushis permitted.peter-evans/create-pull-requestwith a directgit pushback to the triggering branchpr-branch,pr-title, andpr-bodyinputspull-requests: writepermission — onlycontents: writeis neededmain