Skip to content

fix(nix): push hash update directly to triggering branch#77

Merged
drewr merged 1 commit into
mainfrom
fix/nix-direct-push
Jun 3, 2026
Merged

fix(nix): push hash update directly to triggering branch#77
drewr merged 1 commit into
mainfrom
fix/nix-direct-push

Conversation

@drewr

@drewr drewr commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Follows up on #75 — the original PR used peter-evans/create-pull-request which opened a separate PR targeting main. That's wrong: go.mod should never change directly on main, so the workflow will always be triggered from a feature or Renovate branch where a direct git push is permitted.

  • Replaces peter-evans/create-pull-request with a direct git push back to the triggering branch
  • Removes the now-unnecessary pr-branch, pr-title, and pr-body inputs
  • Drops pull-requests: write permission — only contents: write is needed
  • Updates docs to reflect the push-based approach and note that this workflow should not be triggered on main

Drop peter-evans/create-pull-request in favour of a direct git push back
to the branch that triggered the workflow. The go.mod change always arrives
on a feature/Renovate branch, not main, so a direct push is not blocked by
repo rules and keeps the dep update and hash fix in the same branch.
@drewr drewr requested a review from a team as a code owner June 2, 2026 20:26
@drewr drewr requested a review from aflor024 June 2, 2026 20:26

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but is there an Issue somewhere describing what this is trying to accomplish?

@drewr drewr merged commit a626da9 into main Jun 3, 2026
3 checks passed
@drewr drewr deleted the fix/nix-direct-push branch June 3, 2026 19:59
@drewr

drewr commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Right question! Originally datum-cloud/datumctl#199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants