refactor: init secret_key - #1294
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes a hard-coded SQLBot secret key and introduces installer-side secret key initialization/rotation so deployments get a unique, persistent key (and can automatically rotate a known-compromised one).
Changes:
- Add
prepare_secret_keyto the installer to validate/generate a 64-char secret key and auto-rotate a known-compromised key. - Update
installer/install.confto leaveSQLBOT_SECRET_KEYempty by default (installer generates and persists it). - Update
docker-compose.yamlto requireSECRET_KEYto be set via environment interpolation rather than embedding a default key.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| installer/install.sh | Generates/validates/persists SQLBOT_SECRET_KEY, rotates a compromised key, and avoids running main when sourced. |
| installer/install.conf | Removes the default secret key value; documents installer-generated persistence behavior. |
| docker-compose.yaml | Removes hard-coded SECRET_KEY and requires users to set a unique value via .env/environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.