Skip to content

S2704_refresh - #2250

Open
goutamabrol wants to merge 1 commit into
datacommonsorg:masterfrom
goutamabrol:S2704_refresh
Open

goutamabrol wants to merge 1 commit into
datacommonsorg:masterfrom
goutamabrol:S2704_refresh

Conversation

@goutamabrol

@goutamabrol goutamabrol commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

import name - CensusACS5YearSurvey_SubjectTables_S2704
PR checklist - Doc

Summary of Changes

  • Added S2704_spec.json and README.md for US Census ACS 5-Year Subject Table S2704 (Public Health Insurance Coverage by Type and Selected Characteristics) covering 2015–2024 vintages.
  • Added testdata/ (S2704_test.zip, column_map.json, S2704_cleaned.csv, S2704_output.mcf, S2704_output.tmcf, and S2704_summary.json) for unit testing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the US Census ACS 5-Year Subject Table S2704, which provides civilian noninstitutionalized population counts on public health insurance coverage by type, along with corresponding test artifacts and documentation. Feedback on the changes highlights a critical mapping issue in the specification where columns from different sections (total population, those with public health insurance, and percentages) are incorrectly mapped to the same total population StatVars, resulting in duplicate rows and potential data corruption. Additionally, there is a naming inconsistency between the Estimate and Margin of Error StatVars for the Under 18/19 age groups that needs to be resolved for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant