Skip to content

Remove USDA_AgricultureSurvey golden summary report and validation rule - #2223

Open
niveditasing wants to merge 1 commit into
datacommonsorg:masterfrom
niveditasing:fix/usda-agriculture-survey-remove-golden-summary
Open

niveditasing wants to merge 1 commit into
datacommonsorg:masterfrom
niveditasing:fix/usda-agriculture-survey-remove-golden-summary

Conversation

@niveditasing

Copy link
Copy Markdown
Contributor

Removed summary because of mismatch & hence removing goldens as it is already work in progress; will add new goldens as per new instructions.

Removed summary because of mismatch & hence removing goldens as it is already work in progress; will add new goldens as per new instructions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes a CSV file containing agricultural statistics and removes the check_goldens_summary_report validation rule from validation_config.json. The reviewer advises that when golden checks are removed from the validation configuration, any associated golden data files should also be removed from the source_files list in the manifest file.

I am having trouble creating individual review comments. Click here to see my feedback.

scripts/us_usda/quickstats/validation_config.json (12-19)

medium

When golden checks are removed from the validation configuration, please ensure that any associated golden data files (such as golden_summary_report.csv) are also removed from the source_files list in the manifest file.

References
  1. When golden checks are removed from the validation configuration, ensure that any associated golden data files (such as 'golden_data/*.csv') are also removed from the 'source_files' list in the manifest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant