Remove USDA_AgricultureSurvey golden summary report and validation rule - #2223
Open
niveditasing wants to merge 1 commit into
Open
niveditasing wants to merge 1 commit into
niveditasing wants to merge 1 commit into
Conversation
Removed summary because of mismatch & hence removing goldens as it is already work in progress; will add new goldens as per new instructions.
Contributor
There was a problem hiding this comment.
Code Review
This pull request deletes a CSV file containing agricultural statistics and removes the check_goldens_summary_report validation rule from validation_config.json. The reviewer advises that when golden checks are removed from the validation configuration, any associated golden data files should also be removed from the source_files list in the manifest file.
I am having trouble creating individual review comments. Click here to see my feedback.
scripts/us_usda/quickstats/validation_config.json (12-19)
When golden checks are removed from the validation configuration, please ensure that any associated golden data files (such as golden_summary_report.csv) are also removed from the source_files list in the manifest file.
References
- When golden checks are removed from the validation configuration, ensure that any associated golden data files (such as 'golden_data/*.csv') are also removed from the 'source_files' list in the manifest file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed summary because of mismatch & hence removing goldens as it is already work in progress; will add new goldens as per new instructions.