Skip to content

Add Eurostat regional population imports#2055

Open
shvngisingh wants to merge 7 commits into
datacommonsorg:masterfrom
shvngisingh:eurostat_regional_new_imports
Open

Add Eurostat regional population imports#2055
shvngisingh wants to merge 7 commits into
datacommonsorg:masterfrom
shvngisingh:eurostat_regional_new_imports

Conversation

@shvngisingh
Copy link
Copy Markdown
Contributor

Population_on_1_January_by_age_group_and_sex PR checklist = LINK
Usually_resident_population_on_1_January_input PR checklist = LINK

Eurostat Population By Age Group And Sex On January 1 Import name: EuroStat_Population_On_1_January_By_Age_Group_And_Sex
Usually Resident Population On January 1 import name: EuroStat_Usually_Resident_Population_On_1_January

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new Eurostat population data imports: 'PopulationOn1JanByAgeGroupAndSex' and 'Usually_resident_population_on_1_January', along with their configurations, mapping files, test data, and documentation. The review highlights critical security concerns regarding hardcoded API keys and local system paths in the execution scripts, as well as duplicate commands. Additionally, several copy-paste errors were identified in the manifest, place resolution was incorrectly disabled in the metadata, and invalid Data Commons properties were mapped in the PV map. Finally, multiple typos, mismatched directory paths, and syntax errors in the README commands need to be corrected to ensure the import processes run successfully.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread statvar_imports/eurostat/PopulationOn1JanByAgeGroupAndSex/run.sh Outdated
Comment thread statvar_imports/eurostat/Usually_resident_population_on_1_January/run.sh Outdated
Comment thread statvar_imports/eurostat/PopulationOn1JanByAgeGroupAndSex/manifest.json Outdated
Comment thread statvar_imports/eurostat/Usually_resident_population_on_1_January/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant