WHO Tuberculosis Rifampicin Resistant Import Data#2042
WHO Tuberculosis Rifampicin Resistant Import Data#2042pravnkumar-cloudsufi wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new statistical variable import for WHO Tuberculosis treatment outcomes of people with rifampicin-resistant TB. The feedback identifies several critical consistency issues, including duplicate files (such as mainfest.json and who_data_download_tuberculosis_rifampicin_resistant.py), mismatched script and directory paths between manifest.json and README.md, and incorrect test data references. Additionally, the data download script should raise exceptions on HTTP errors to fail loudly in automated environments rather than returning silently, and hardcoded paths should be avoided to prevent brittle execution.
|
Hello! I have reviewed your pull request for the WHO Tuberculosis Rifampicin Resistant data import. The implementation is well-structured and follows the repository's established patterns for new imports. I noticed a minor typo in the filename |
PR Checklist: https://docs.google.com/spreadsheets/d/1DP2SvoEwoU6VXvKucE9xiABKRVDzEx-D/edit?usp=drive_link&ouid=112402773742366011389&resourcekey=0-AaGcMXwYDzrz9obQi2_JbQ&rtpof=true&sd=true
Import Name:
WHO Tuberculosis Rifampicin Resistant - WHO_TuberculosisRifampicinResistant