Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Claude end-to-end expectation still uses the raw version and must be updated.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Stabilizes Claude’s managed User-Agent by omitting local build metadata, preventing unnecessary settings rewrites.
Changes:
- Use the stable release version in Claude headers.
- Add regression coverage for local build versions.
File summaries
| File | Summary |
|---|---|
tests/test_agent_claude.py |
Tests omission of local build metadata. |
src/ucode/agents/claude.py |
Uses the stable version in managed headers. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| header_lines = [ | ||
| "x-databricks-use-coding-agent-mode: true", | ||
| f"User-Agent: ucode/{ucode_version()} claude/{agent_version('claude')}", | ||
| f"User-Agent: ucode/{ucode_version().split('+', 1)[0]} claude/{agent_version('claude')}", |
Author
|
Addressed the review finding. Claude uses the shared release-version formatter, and the end-to-end header expectation applies the same rule. |
Comment on lines
+460
to
+461
| monkeypatch.setattr(claude, "ucode_release_version", lambda: "0.1.0") | ||
| monkeypatch.setattr(claude, "agent_version", lambda binary: "2.1.136") |
There was a problem hiding this comment.
🟡 Changes recommended
The E2E Claude User-Agent expectation must be aligned with the production header format.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+129
to
+130
| version = ucode_release_version() if agent_name == "claude" else ucode_version() | ||
| return f"ucode/{version} {agent_name}/{agent_version(binary)}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build metadata in Claude's managed User-Agent changed after every local ucode update, which made each launch rewrite root-owned settings and request sudo.
Use the stable release version in the managed header so local build changes do not rewrite the file.