Conversation
xsh310
added this pull request to stack #576
September 11, 2026 21:08
xsh310
marked this pull request as ready for review
September 12, 2026 07:13
xsh310
force-pushed
the
skills-picker-ui-package
branch
2 times, most recently
from
September 14, 2026 03:08
1bdcfcd to
57a9a3e
Compare
xsh310
force-pushed
the
skills-picker-ui-package
branch
from
September 14, 2026 20:09
57a9a3e to
ce2c6c7
Compare
sunishsheth2009
approved these changes
Sep 14, 2026
xsh310
force-pushed
the
skills-picker-ui-package
branch
8 times, most recently
from
September 15, 2026 04:42
576c37c to
58353b8
Compare
Turn ui.py into a ui/ package and move the streaming multi-select picker primitives (scrolling_checkbox, StreamingInquirerControl, merge_new_choices, picker_style, PICKER_VISIBLE_ROWS) out of mcp.py into ui/interactive_picker.py, re-exported from ucode.ui. Add a loading_noun parameter so non-MCP pickers can label the loading footer. No behavior change; picker unit tests move to tests/test_interactive_picker.py. Co-authored-by: Isaac <no-reply@databricks.com>
xsh310
force-pushed
the
skills-picker-ui-package
branch
from
September 15, 2026 14:43
58353b8 to
0e016c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why?
Change: Turn
src/ucode/ui.pyinto aui/package and move the streaming multi-select picker primitives —scrolling_checkbox,StreamingInquirerControl,merge_new_choices,picker_style, andPICKER_VISIBLE_ROWS(renamed fromMCP_PICKER_VISIBLE_ROWS) — out ofmcp.pyinto a newsrc/ucode/ui/interactive_picker.py, re-exported fromucode.ui. Added aloading_nounparameter (default"MCP services") so a non-MCP picker can label its loading footer.Why: These primitives are source-agnostic UI. Extracting them lets the upcoming
ug skill add(download path) picker reuse them without importing frommcp.py. This is the first PR (PR A) in theug skill addinteractive-picker stack; it is a pure refactor with no behavior change.How do you know it works?
Testing:
ruff check .is clean and the fulluv run pytestsuite passes, except two pre-existing e2e failures (test_e2e_user_agent,test_claude_smart_routing_v2) that also fail onmain. The picker unit tests moved totests/test_interactive_picker.py; the MCP picker tests intests/test_mcp.py, retargeted to the moved symbols, stay green.This pull request and its description were written by Isaac.