test: cover the relayed-proxy 401 refresh-failure hint - #377
Open
masonc08 wants to merge 1 commit into
Open
Conversation
Adds test_failed_refresh_surfaces_reauth_hint to TestRetryOn401 — forces a 401 plus a refresh that raises and asserts the `databricks auth login` hint prints and the response is still relayed. Guards the fix commit on this branch. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the unit test that should have shipped with #374 (the relayed-proxy 401 re-auth hint), which merged without it. It covers the retry-on-401 path where the forced Databricks token refresh itself fails: it asserts the
databricks auth loginhint is printed and the response is still relayed. Slots intoTestRetryOn401next to the success-retry and persistent-401 cases.Why a separate PR
#374 merged before this test was pushed. This lands it against the now-merged fix — no production code change.
Testing
uv run pytest tests/test_gateway_proxy.py -q→ 24 passed (incl. the newtest_failed_refresh_surfaces_reauth_hint), against the merged fix onmain.This pull request and its description were written by Isaac.