Skip to content

Bump eslint from 8.57.1 to 10.6.0 in /packages/databricks-vscode-types#1935

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/packages/databricks-vscode-types/eslint-10.6.0
Open

Bump eslint from 8.57.1 to 10.6.0 in /packages/databricks-vscode-types#1935
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/packages/databricks-vscode-types/eslint-10.6.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps eslint from 8.57.1 to 10.6.0.

Release notes

Sourced from eslint's releases.

v10.6.0

Features

  • b1f9106 feat: detect Symbol() and BigInt() in no-constant-binary-expression (#20981) (Taejin Kim)
  • f291007 feat: add checkRelationalComparisons to no-constant-binary-expression (#20948) (sethamus)

Bug Fixes

  • 6b05784 fix: prefer-exponentiation-operator invalid autofix at statement start (#20997) (Milos Djermanovic)
  • bb9eb2a fix: account for shadowed Boolean in no-extra-boolean-cast (#21013) (den$)
  • 8fd8741 fix: don't report shadowed undefined in radix rule (#21011) (Pixel)
  • 5784980 fix: don't report shadowed undefined in no-throw-literal (#21010) (Pixel)
  • 9cd1e6d fix: suppress invalid class suggestion in no-promise-executor-return (#21008) (Pixel)
  • d4eb2dc fix: don't report shadowed undefined in prefer-promise-reject-errors (#21006) (Pixel)
  • 2360464 fix: prefer-promise-reject-errors false positives for shadowed Promise (#21003) (den$)
  • 63d52d2 fix: restore max-classes-per-file report range (#21002) (Pixel)
  • 7feaff0 fix: callback detection logic for IIFEs in max-nested-callbacks (#20979) (fnx)
  • 399a2ec fix: don't report inner non-callbacks in max-nested-callbacks (#20995) (Milos Djermanovic)

Documentation

  • a83683d docs: Update README (GitHub Actions Bot)
  • f5449f9 docs: document userland patterns for global assertionOptions in RuleT… (#20986) (playgirl)
  • bea49f7 docs: Update README (GitHub Actions Bot)
  • e5f70f9 docs: update code-path diagrams (#20984) (Tanuj Kanti)
  • 8890c2d docs: add TypeScript config guidance for MCP server (#20796) (Pierluigi Lenoci)
  • 3eb3d9b docs: Update README (GitHub Actions Bot)
  • c5bb59c docs: Update README (GitHub Actions Bot)
  • eb3c97c docs: fix grammar in prefer-const rule description (#20983) (lumir)

Chores

  • 6a42034 ci: run ecosystem tests on main branch (#20891) (sethamus)
  • 3dbacdb ci: bump actions/checkout from 6 to 7 (#21014) (dependabot[bot])
  • c3abfca chore: correct JSDoc param types in html formatter (#21018) (Minseon Kim)
  • a832320 ci: split ecosystem tests into separate jobs (#21001) (xbinaryx)
  • 27166e7 chore: update ecosystem plugins (#21005) (ESLint Bot)
  • 865d76e ci: bump pnpm/action-setup from 6.0.8 to 6.0.9 (#20989) (dependabot[bot])
  • 27a88c9 chore: update dependency markdown-it to v14 in root (#20994) (Milos Djermanovic)
  • 970cea6 chore: update dependency markdown-it to v14 (#20993) (Milos Djermanovic)
  • b482120 chore: update dependency prettier to v3.8.4 (#20990) (renovate[bot])
  • 6993fb3 chore: update ecosystem plugins (#20985) (ESLint Bot)

v10.5.0

Features

  • 5ca8c52 feat: correct stack tracking in max-nested-callbacks (#20973) (Pixel998)
  • b565783 feat: report no-with violations at the with keyword (#20971) (Pixel998)
  • 2ce032f feat: report max-lines-per-function violations at function head (#20966) (Pixel998)
  • 732cb3e feat: report max-nested-callbacks violations at function head (#20967) (Pixel998)
  • f9c138a feat: report max-depth violations on keywords (#20943) (Pixel998)
  • bdb496c feat: correct max-depth handling for else-if chains (#20944) (Pixel998)
  • c296873 feat: update error loc in max-statements to function header (#20907) (Taejin Kim)

Documentation

... (truncated)

Commits
  • 5d12a04 10.6.0
  • f7ca54b Build: changelog update for 10.6.0
  • 6a42034 ci: run ecosystem tests on main branch (#20891)
  • b1f9106 feat: detect Symbol() and BigInt() in no-constant-binary-expression (#20981)
  • 3dbacdb ci: bump actions/checkout from 6 to 7 (#21014)
  • c3abfca chore: correct JSDoc param types in html formatter (#21018)
  • a83683d docs: Update README
  • a832320 ci: split ecosystem tests into separate jobs (#21001)
  • 6b05784 fix: prefer-exponentiation-operator invalid autofix at statement start (#20997)
  • bb9eb2a fix: account for shadowed Boolean in no-extra-boolean-cast (#21013)
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 30, 2026
@dependabot dependabot Bot temporarily deployed to test-trigger-is June 30, 2026 17:22 Inactive
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/packages/databricks-vscode-types/eslint-10.6.0 branch from 3fb078c to f45de7f Compare July 2, 2026 11:32
@dependabot dependabot Bot temporarily deployed to test-trigger-is July 2, 2026 11:34 Inactive
@rugpanov

rugpanov commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Integration tests triggered automatically for f45de7ff via vscode-isolated-pr.yml.

Checks will be approved automatically on success.

@dependabot
Bump eslint from 8.57.1 to 10.6.0 in /packages/databricks-vscode-types
9154edc 
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.6.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v8.57.1...v10.6.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.6.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/packages/databricks-vscode-types/eslint-10.6.0 branch from f45de7f to 9154edc Compare July 3, 2026 11:03
@dependabot dependabot Bot temporarily deployed to test-trigger-is July 3, 2026 11:03 Inactive
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/vscode

Inputs:

  • PR number: 1935
  • Commit SHA: 9154edc3b3fe8f1b7bc50a3ca98b0d05661b13e7

Checks will be approved automatically on success.

@rugpanov

rugpanov commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Integration tests ❌ 3 of 4 test jobs failed for 9154edc3 (0 passed, 1 skipped).
View run

@rugpanov

rugpanov commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Recommendation: hold — this is an ESLint flat-config migration, not a version bump, and the target version doesn't exist.

Blocker 1: target version is phantom

eslint@10.6.0 returns npm E404 — the latest published eslint is 10.5.0 (dist-tags: latest: 10.5.0). So this PR can't resolve as written.

Blocker 2: flat config is mandatory (the real work)

The repo uses legacy .eslintrc.json (two files: root ./.eslintrc.json and packages/databricks-vscode/.eslintrc.json). ESLint 9 made flat config (eslint.config.js) the default; ESLint 10 removes eslintrc support entirely. Migrating requires:

  • Rewrite both .eslintrc.json → eslint.config.js (flat-config format).
  • Convert extends (eslint:recommended, plugin:@typescript-eslint/recommended, prettier) into flat-config imports — typescript-eslint flat config uses the tseslint.config() / tseslint.configs.recommended helpers.
  • Port plugins (@typescript-eslint, no-only-tests, eslint-plugin-local-rules) to imported plugin objects.
  • Re-express the overrides blocks (test-file rules like no-console/no-unused-expressions off, apis/* rules) as flat-config entries with files globs.
  • Rework the custom local-rules wiring — eslint-local-rules/index.js currently does require("ts-node").register(...) to load the mutex-synchronised-decorator rule; flat config loads plugins differently and this mechanism needs rethinking.
  • Verify yarn test:lint still enforces every rule (esp. confirm local-rules/mutex-synchronised-decorator stays active, as we checked in Bump eslint-plugin-local-rules from 2.0.1 to 3.0.2 #1959).

Blocker 3: Node engine

eslint 10 requires Node ^20.19 || ^22.13 || >=24 (we're on 22+, so OK — just noting the raised floor).

What's already ready

typescript-eslint v8 (merged in #1956) already peer-supports eslint 10 (^8.57.0 || ^9.0.0 || ^10.0.0), and eslint-config-prettier / no-only-tests have loose peers.

Suggested path (two steps)

  1. A dedicated "migrate to ESLint flat config" PR, landing on eslint 9 first (flat config works there; lower risk than jumping straight to 10).
  2. Then bump to eslint 10.5.0 (the real latest) once flat config is in place.

Keeping this open as a tracker for that migration.

@rugpanov rugpanov added the deferred Blocked on prerequisite work; revisit later label Jul 3, 2026
@rugpanov rugpanov mentioned this pull request Jul 3, 2026
Merged
rugpanov added a commit that referenced this pull request Jul 3, 2026
@rugpanov
Ignore ESM-only and VS Code engine-coupled major bumps in Dependabot (#…
d4b8d6d 
…1961)

## Why

Several Dependabot major-version PRs are blocked on prerequisite work
and aren't ready to merge. Left as open PRs (or closed), Dependabot
keeps re-raising them under new version numbers. Scoped `ignore` rules
park them until the prerequisite work is done — keeping the PR queue
clean without losing the rationale.

This directly answers "if I close these, will the bot reopen them?" —
**yes, under new versions**, unless we add these ignore rules.

## What

In `.github/dependabot.yml`, add `ignore` rules (scoped to the packages
that declare each dep):

**ESM-only majors** — blocked until the build/test tooling migrates off
`ts-node` (CommonJS) to an ESM runner (`tsx`):
- `yargs >=18` (see #1934)
- `chai >=5`, `@types/chai >=5` (see #1932)

**VS Code engine-coupled** — `@types/vscode` must track `engines.vscode`
(`^1.86.0`); bump both together only when the minimum supported VS Code
is deliberately raised (see #1933):
- `@types/vscode >=1.87` (in both `/packages/databricks-vscode` and
`/packages/databricks-vscode-types`)

Each rule carries an inline comment pointing to its tracking PR and
unblock condition, so the ignore can be removed intentionally later.

## Verification

- `.github/dependabot.yml` parses as valid YAML; ignore rules confirmed
on both affected directory entries.

**Backward compatibility:** dependency-automation config only; no
runtime, API, or build-output change.

Once this merges, PRs #1932 / #1933 / #1934 can be closed without
Dependabot re-raising those major lines. (#1931 typescript and #1935
eslint are **not** ignored — those aren't version-availability issues,
they're migrations we may still want prompts for.)

This pull request and its description were written by Isaac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

deferred Blocked on prerequisite work; revisit later dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rugpanov