ci(kernel): add packaged-binary e2e job (npm-installed kernel) - #437
Open
msrathore-db wants to merge 1 commit into
Open
msrathore-db wants to merge 1 commit into
msrathore-db wants to merge 1 commit into
Conversation
Re-adds run-kernel-e2e-packaged: instead of build:native, npm ci installs the published @databricks/databricks-sql-kernel-linux-x64-gnu from JFrog db-npm, asserts the binding loads from node_modules (not a local build), and runs the SELECT 1 e2e against it — validating the optionalDependencies path a released driver actually uses, which build:native never covers. Now that the kernel scope is allowlisted through db-npm curation, this resolves and passes. Same gate/runner/warehouse as run-kernel-e2e. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
msrathore-db
added
the
kernel-e2e
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds the
run-kernel-e2e-packagedjob tokernel-e2e.yml. Unlikerun-kernel-e2e(which builds the binding viabuild:native), this job installs the published@databricks/databricks-sql-kernel-<triple>package vianpm ci(theoptionalDependenciesa released driver uses, resolved through JFrogdb-npm), asserts the binding loads fromnode_modules(not a local build), and runs theSELECT 1e2e against it.This is the only CI coverage of the path a real
npm installconsumer takes —build:nativenever exercises it.Why now
It was dropped from the consume PR (#434) because the kernel
0.2.0packages were blocked by JFrogdb-npm's 7-day curation cooldown, sonpm cicouldn't resolve them. The scope is now allowlisted through curation, so the packages resolve and this job passes — verified by the unit-test matrix (incl. Node 14) now going green onmain.What it does
npm ci→ installs thelinux-x64-gnukernel optional dep fromdb-npm(nobuild:native)require.resolve('@databricks/databricks-sql-kernel-linux-x64-gnu')points intonode_modulesand the binding loadstests/e2e/kernel/select-one-e2e.test.ts(SELECT 1 viauseKernel) against the dogfood warehouseSame gate (
detect-changes), runner, andazure-prodenvironment asrun-kernel-e2e. No custom check — its own job status is the signal.This pull request and its description were written by Isaac.