Repository navigation
Fix sandbox startup polling through transient Stopped states - #7010
Open
arkaly24-cloud wants to merge 2 commits into
Open
arkaly24-cloud wants to merge 2 commits into
arkaly24-cloud wants to merge 2 commits into
Conversation
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stoppedstates during sandbox startup and retry start requests at most once every 15 seconds.Why
An accepted start request can be followed by a transient
Stoppedstatus. Treating the first such poll as terminal makesdatabricks sandbox startanddatabricks sandbox sshfail before the sandbox can recover.Tests
GOTOOLCHAIN=go1.26.8 go test ./cmd/sandbox -count=1go test -race ./cmd/sandbox -count=1go vet ./cmd/sandboxGOTOOLCHAIN=go1.26.8 go tool -modfile=tools/go.mod golangci-lint run --allow-parallel-runners -j=4 ./cmd/sandbox/...python3.12 tools/validate_nextchanges.py./task checks, Go/YAML formatting, and full Go lint passed with Go 1.26.8.Full acceptance testing stopped at its prerequisite check because this machine has
jq1.6, while the suite requires 1.7 or newer. Python formatting/lint could not run because downloading the pinned Ruff version failed on PyPI DNS resolution. No unrelated code changes were made for these environment limitations.This PR was written with Codex.