Repository navigation
Add features bundle resource - #6952
Open
Daniel114510 wants to merge 5 commits into
Open
Daniel114510 wants to merge 5 commits into
Daniel114510 wants to merge 5 commits into
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 17080fa
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
featuresas a bundle resource type, so a Feature Engineering feature can be declared indatabricks.ymland deployed, updated and destroyed like any other resource.UpdateFeatureacceptsdescriptionand nothing else, so the adapter sends a staticupdate_mask=description; every other field is excluded at plan level, withfull_name,sourceandfunctionmarkedrecreate_on_changesfrom the spec'sIMMUTABLEannotations. Literal catalog and schema names infull_nameare rewritten into${resources.…}references so a feature deploys after the catalog and schema it lives in.Why
Features are currently created through the Python client or the API. Onboarding Features to direct engine is part of the proper DAB support effort for the Feature Engineering API.
Tests
go test ./bundle/... ./libs/... ./internal/... ./cmd/... ./experimental/ssh/... .— passedgo test ./acceptance— passedtask generate-check— no drifttask checks,task fmt— passedAcceptance tests added:
bundle/resources/features/basic— full lifecycle, request tracebundle/resources/features/lifecycle— cloud-capable, provisions its own tablebundle/resources/features/remote-delete— out-of-band delete driftbundle/deployment/bind/feature— bind and unbindbundle/invariant/configs/feature.yml.tmpl— invariant coveragelibs/testserver/feature.go— fake create/get/update/deletecmd/experimental/workspace_open_test.go—featuresURL and resource-type listsLive-tested against a workspace with lite-swapped Feature Store. Tested for Delta-sourced batch feature, a Kafka-stream-sourced feature, and a sawtooth-window feature. For each feature: CRUD, bind and unbind, a second
bundle planreported no changes after create and update, changing an immutable field planned a recreate every time.