direct: keep the state file's mode when saving - #6364
Open
denik wants to merge 2 commits into
Open
Conversation
Saving writes a temp file and renames it into place, and a temp file always starts at 0o600, so an existing state file that was deliberately readable to a group or to CI narrowed on every save. Writing in place, before v1.13.0, left the mode alone. Carry the replaced file's mode over to the temp file before the rename. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: a99ea12
6 interesting tests: 4 SKIP, 1 RECOVERED, 1 flaky
Top 13 slowest tests (at least 2 minutes):
|
…kept Persisting the state matters more than its mode, so neither the stat nor the chmod should abort the save. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v1.13.0 the state file is written as a temp file and renamed into place. A temp file always starts at
0o600, so an existing state file that was deliberately readable to a group or to CI narrowed on every save — writing in place used to leave the mode alone.Carry the replaced file's mode over to the temp file before the rename.