Pass PlanEntry to DoUpdateWithID - #6360
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 94ba811
6 interesting tests: 4 SKIP, 1 RECOVERED, 1 flaky
Top 11 slowest tests (at least 2 minutes):
|
DoUpdate receives the PlanEntry so it can tell what the plan is changing; DoUpdateWithID did not, so the rename paths had no way to consult it. Pure plumbing: carry the argument through the interface, the adapter and apply. No implementer reads it yet, so behaviour is unchanged. The UC rename paths use it in a follow-up, where an omitempty field the plan reports as cleared has to be force-sent or the rename drops the clear. Co-authored-by: Isaac
denik
force-pushed
the
denik/update-with-id-planentry
branch
from
August 24, 2026 12:53
e9bd2fc to
94ba811
Compare
denik
marked this pull request as ready for review
August 24, 2026 13:07
shreyas-goenka
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We already pass it to DoUpdate, so it was just an omission.
Planned to be used in #6343