job_runs: plan skip for in-progress runs and trigger removal - #6357
Merged
Conversation
radakam
marked this pull request as ready for review
August 24, 2026 10:04
Collaborator
Integration test reportCommit: 59d0cb6
6 interesting tests: 4 SKIP, 1 RECOVERED, 1 flaky
Top 7 slowest tests (at least 2 minutes):
|
denik
approved these changes
Aug 24, 2026
Keep update semantics for adopting an in-progress run while moving its wait to the framework hook, and treat removal of on_bundle_deploy as unchanged.
radakam
force-pushed
the
job-runs-fix-update-actions
branch
from
August 24, 2026 11:00
c8fbdd5 to
86fe2a3
Compare
radakam
enabled auto-merge
August 24, 2026 11:00
denik
reviewed
Aug 24, 2026
denik
self-requested a review
August 24, 2026 11:08
Contributor
I don't understand this. Why not: "plan skip rather than update when job run is in progress" |
radakam
disabled auto-merge
August 24, 2026 11:11
A run that is still going should not be recreated, but skip is the plan action that leaves it alone. That also drops DoUpdate, so an interrupted wait is not resumed; interrupted_run records that limitation.
radakam
changed the title
denik
approved these changes
Aug 24, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
Should be included in .nextchanges as well, since it's affects user-visible plan
Collaborator
Integration test reportCommit: 15e3d2f
68 interesting tests: 32 FAIL, 32 flaky, 2 SKIP, 1 KNOWN, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DoUpdate.on_bundle_deployis removed, instead of a state-only update.Why
A run that is still going should not be recreated, but skip is the action that leaves it alone. That also means an interrupted wait is not resumed.
Removing a trigger requires no action: it should neither re-run the job nor report a resource update.
Tests
interrupted_runasserts skip for an in-progress run and records the Badness that the next deploy does not wait.on_bundle_deploycovers trigger removal as unchanged.