direct: fail bind when the deployment state cannot be read - #6331
Open
denik wants to merge 1 commit into
Open
Conversation
Collaborator
Integration test reportCommit: 134ca03
Top 3 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Aug 20, 2026
Bind treated any failure to open the state as "resource not bound": it skipped the already-managed check and then bound over state whose ownership was never verified, overwriting it. A crashed deploy that left a WAL behind was enough to trigger this, and bind still reported success. A state file that does not exist opens as an empty one, so absence of a binding is already covered; return the error instead. Co-authored-by: Isaac
denik
force-pushed
the
denik/bind-state-open-error
branch
from
August 24, 2026 09:35
70ec539 to
134ca03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle deployment bindtreated any failure to open the state as "resource not bound": it skipped the already-managed check, bound over state whose ownership was never verified, and overwrote it — while reporting success. A crashed deploy that left a WAL behind was enough to trigger this.A state file that does not exist opens as an empty one, so the absence of a binding is already covered by a successful open. Return the error instead.
Tests
New acceptance test that deploys a job, leaves a WAL from a different lineage next to the state, and binds: it used to print "Successfully bound" and replace the state file.