test_matrix_transpose: avoid calling asarray on nested sequence of arrays - #463
Merged
Conversation
ev-br
approved these changes
Sep 6, 2026
ev-br
left a comment
ev-br
left a comment
Member
There was a problem hiding this comment.
Ran $ ARRAY_API_TESTS_MODULE=numpy pytest array_api_tests/test_linalg.py::test_matrix_transpose -v --max-examples=50_000 to triple-check that using stack does not throw off numpy's indexing returning scalars not 0D arrays, and it passed. Thus all is well, and the fix is clearly improves the Array API compatibility.
Merging, thanks @mdhaber.
I'll send a follow-up to clean up the duplication of
from . import _array_module
from . import _array_module as xp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-461