Skip to content

fix(dapi): bound request metric labels#4151

Open
QuantumExplorer wants to merge 1 commit into
v4.1-devfrom
codex/fix-dapi-metric-labels
Open

fix(dapi): bound request metric labels#4151
QuantumExplorer wants to merge 1 commit into
v4.1-devfrom
codex/fix-dapi-metric-labels

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Keeps request telemetry within a finite, server-controlled label vocabulary. Covers internal review items 001, 002, and 294.

What was done?

  • Allowlisted registered Core and Platform gRPC routes.
  • Replaced unknown protocol paths and methods with fixed fallback buckets.
  • Restricted method-label construction to static values.
  • Added high-cardinality regression coverage for gRPC, JSON-RPC, and generic HTTP inputs.

How Has This Been Tested?

  • Full rs-dapi unit and documentation suite: 285 tests.
  • Strict Clippy for rs-dapi across all targets.
  • Workspace formatting check.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6ac6ed3b-ccc2-4ae9-b2dd-d8755bd4c0cd

📥 Commits

Reviewing files that changed from the base of the PR and between fc05d62 and 79b8d96.

📒 Files selected for processing (2)
  • packages/rs-dapi/src/metrics.rs
  • packages/rs-dapi/src/server/jsonrpc.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-dapi-metric-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer marked this pull request as ready for review July 21, 2026 02:04
@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Ready for review — 22 ahead in queue (commit 79b8d96)
Queue position: 23/27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants