Skip to content

fix(drive): order ascending cursor range bounds#4148

Open
QuantumExplorer wants to merge 1 commit into
v4.1-devfrom
codex/fix-document-cursor-ranges
Open

fix(drive): order ascending cursor range bounds#4148
QuantumExplorer wants to merge 1 commit into
v4.1-devfrom
codex/fix-document-cursor-ranges

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

What

  • construct ascending less-than cursor ranges with the cursor as the lower bound
  • preserve startAt versus startAfter inclusivity for both less-than operators
  • add a regression matrix covering all four affected range forms

Why

The previous endpoint order produced reversed GroveDB ranges for ascending queries whose cursor was below the predicate bound. The proof and no-proof paths share this construction, so correcting it restores the query semantics at their common boundary.

This covers PLATFORM-DS-CAND-388.

Checks

  • cargo test -p drive --features server query::conditions::tests (205 passed)
  • cargo clippy -p drive --features server --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fae594f6-bb92-4e94-a8b8-808b390a90a2

📥 Commits

Reviewing files that changed from the base of the PR and between fc05d62 and 9f62a35.

📒 Files selected for processing (1)
  • packages/rs-drive/src/query/conditions.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-document-cursor-ranges

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 20, 2026
@QuantumExplorer
QuantumExplorer marked this pull request as ready for review July 21, 2026 02:04
@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Ready for review — 24 ahead in queue (commit 9f62a35)
Queue position: 25/27

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.45%. Comparing base (fc05d62) to head (9f62a35).
⚠️ Report is 1 commits behind head on v4.1-dev.

Files with missing lines Patch % Lines
packages/rs-drive/src/query/conditions.rs 98.41% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           v4.1-dev    #4148      +/-   ##
============================================
+ Coverage     87.43%   87.45%   +0.01%     
============================================
  Files          2646     2648       +2     
  Lines        333981   334236     +255     
============================================
+ Hits         292023   292304     +281     
+ Misses        41958    41932      -26     
Components Coverage Δ
dpp 88.44% <ø> (ø)
drive 86.15% <98.41%> (+<0.01%) ⬆️
drive-abci 89.57% <ø> (+0.05%) ⬆️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.88% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 49.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants