ci(swift-sdk): isolate fork builds from self-hosted runner#4102
Closed
QuantumExplorer wants to merge 3 commits into
Closed
ci(swift-sdk): isolate fork builds from self-hosted runner#4102QuantumExplorer wants to merge 3 commits into
QuantumExplorer wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 633 files, which is 533 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (635)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
🕓 Ready for review — 1 ahead in queue (commit 68e5589) |
thepastaclaw
suggested changes
Jul 12, 2026
thepastaclaw
left a comment
thepastaclaw
left a comment
Collaborator
There was a problem hiding this comment.
Code Review
This PR adds guards to keep fork pull requests off the persistent Swift self-hosted runner, plus an offline consistency checker, but every control is evaluated from fork-controlled PR content. The verifier also confirmed a trusted-fork policy inconsistency and a fragile regex-based checker.
Source (experiment sonnet-primary-opus-quarter-sample-20260710, cohort sonnet_primary, bucket 3): reviewers codex/general=gpt-5.6-sol(completed), sonnet5/general=claude-sonnet-5(completed); verifier=verifier-sonnet5-4102-1783889464=claude-sonnet-5; orchestrator=openai/gpt-5.6-sol reasoning=high (orchestration-only, not reviewer/verifier).
🔴 1 blocking | 🟡 1 suggestion(s) | 💬 1 nitpick(s)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `.github/workflows/tests.yml`:
- [BLOCKING] .github/workflows/tests.yml:348-357: Guard lives entirely inside fork-controlled content, so it doesn't close DS-CAND-103 against a real attacker
For pull_request events, GitHub runs workflow YAML from the PR merge commit, and the local reusable workflow resolves from that same commit. A malicious fork therefore controls the caller guard, the callee guard, and the checked-out policy checker, and can weaken all three together. Keep these checks as defense in depth, but close the trust boundary with a server-side control the PR cannot edit, such as required environment approval or repository/organization approval for outside-collaborator workflow runs.
In `.github/workflows/swift-sdk-build.yml`:
- [SUGGESTION] .github/workflows/swift-sdk-build.yml:9-11: New guard omits the repo's established `thepastaclaw` trusted-fork exception
Sibling self-hosted workflows allow `thepastaclaw`-owned fork PRs, while this new Swift guard only accepts same-repository PRs. If that stricter policy is intentional, document it; otherwise match the established exception consistently in the caller, callee, and checker.
Comment on lines
+348
to
357
| if: >- | ||
| ${{ always() | ||
| && (github.event_name != 'pull_request' | ||
| || github.event.pull_request.head.repo.full_name == github.repository) | ||
| && needs.changes.outputs.swift-sdk-changed == 'true' | ||
| && needs.changes.result != 'failure' | ||
| && needs.rs-workspace-tests.result != 'failure' | ||
| && needs.rs-wallet-tests.result != 'failure' }} | ||
| secrets: inherit | ||
| uses: ./.github/workflows/swift-sdk-build.yml |
Collaborator
There was a problem hiding this comment.
🔴 Blocking: Guard lives entirely inside fork-controlled content, so it doesn't close DS-CAND-103 against a real attacker
For pull_request events, GitHub runs workflow YAML from the PR merge commit, and the local reusable workflow resolves from that same commit. A malicious fork therefore controls the caller guard, the callee guard, and the checked-out policy checker, and can weaken all three together. Keep these checks as defense in depth, but close the trust boundary with a server-side control the PR cannot edit, such as required environment approval or repository/organization approval for outside-collaborator workflow runs.
source: ['codex-general', 'sonnet5-general']
Comment on lines
+9
to
+11
| if: >- | ||
| github.event_name != 'pull_request' | ||
| || github.event.pull_request.head.repo.full_name == github.repository |
Collaborator
There was a problem hiding this comment.
🟡 Suggestion: New guard omits the repo's established thepastaclaw trusted-fork exception
Sibling self-hosted workflows allow thepastaclaw-owned fork PRs, while this new Swift guard only accepts same-repository PRs. If that stricter policy is intentional, document it; otherwise match the established exception consistently in the caller, callee, and checker.
source: ['sonnet5-general']
Comment on lines
+33
to
+78
| ( | ||
| index | ||
| for index, line in enumerate(lines) | ||
| if start_pattern.match(line.rstrip("\n")) | ||
| ), | ||
| None, | ||
| ) | ||
| if start is None: | ||
| return "" | ||
|
|
||
| end = len(lines) | ||
| for index in range(start + 1, len(lines)): | ||
| if sibling_pattern.match(lines[index].rstrip("\n")): | ||
| end = index | ||
| break | ||
| return "".join(lines[start:end]) | ||
|
|
||
|
|
||
| def job_property(block: str, property_name: str) -> str: | ||
| """Return one job-level property, excluding step-level lookalikes.""" | ||
| lines = block.splitlines(keepends=True) | ||
| start_pattern = re.compile(rf"^ {re.escape(property_name)}:\s*(?:.*)?$") | ||
| sibling_pattern = re.compile(r"^ [A-Za-z0-9_-]+:\s*(?:.*)?$") | ||
|
|
||
| start = next( | ||
| ( | ||
| index | ||
| for index, line in enumerate(lines) | ||
| if start_pattern.match(line.rstrip("\n")) | ||
| ), | ||
| None, | ||
| ) | ||
| if start is None: | ||
| return "" | ||
|
|
||
| end = len(lines) | ||
| for index in range(start + 1, len(lines)): | ||
| if sibling_pattern.match(lines[index].rstrip("\n")): | ||
| end = index | ||
| break | ||
| return "".join(lines[start:end]) | ||
|
|
||
|
|
||
| def normalized_if(block: str) -> str: | ||
| """Normalize one job condition for an exact policy comparison.""" | ||
| condition = job_property(block, "if") |
Collaborator
There was a problem hiding this comment.
💬 Nitpick: Regex-based YAML folding is fragile to harmless reformatting
The checker depends on exact indentation and manual line folding, so semantically neutral YAML reformatting can cause false CI failures. It fails closed, but structured YAML parsing would reduce maintenance risk.
source: ['sonnet5-general']
QuantumExplorer
changed the title
Address review findings on the DS-CAND-103 guards: - Extend the caller and callee guards with the thepastaclaw trusted-fork exception used by tests-rs-wallet.yml and tests-rs-workspace.yml, so the Swift job applies the same policy as the sibling self-hosted workflows. - Rewrite the policy checker on structured YAML parsing (PyYAML) so harmless reformatting cannot break CI while any semantic change to the guard expressions still fails the check. - Document that the in-repo guards are defense in depth: for pull_request events GitHub evaluates workflow YAML from the PR merge commit, so the authoritative trust boundary is the server-side Actions approval requirement for outside-collaborator workflow runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
requested review from
ZocoLini,
lklimek,
llbartekll and
shumkov
as code owners
July 21, 2026 13:26
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.1-dev #4102 +/- ##
=========================================
Coverage 87.45% 87.45%
=========================================
Files 2648 2650 +2
Lines 334328 334398 +70
=========================================
+ Hits 292373 292443 +70
Misses 41955 41955
🚀 New features to boost your workflow:
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Fixes DS-CAND-103: fork pull requests could route repository-controlled Swift SDK code onto the persistent self-hosted macOS runner.
What was done?
thepastaclaw-owned fork, matching the policy of the sibling self-hosted workflows (tests-rs-wallet.yml,tests-rs-workspace.yml) — before invoking the reusable Swift workflow.changesjob (pull requests, pushes tov*-dev, and the nightly schedule).pull_requestevents GitHub evaluates workflow YAML from the PR merge commit, so a malicious fork can edit the guards and the checker together. The authoritative trust boundary is the server-side Actions approval requirement for outside-collaborator workflow runs; the guards and checker protect trusted runs against accidental regressions.Review round 2
thepastaclawtrusted-fork exception to the caller guard, the callee guard, and the checker, for consistency with the sibling self-hosted workflows.How Has This Been Tested?
|| truebypass is rejected on both the caller and the callee guard.git diff --checkpasses.Breaking Changes
None. Same-repository pull requests, pushes, schedules, and manual runs preserve their existing eligibility, as do trusted
thepastaclaw-owned fork PRs. Other fork pull requests no longer allocate the persistent Swift self-hosted runner.Checklist:
For repository code-owners and collaborators only