Skip to content

build: bump rust-dashcore to v0.42-dev 0093278#3532

Open
lklimek wants to merge 2 commits intov3.1-devfrom
feat/bump-rust-dashcore-v0.42-dev
Open

build: bump rust-dashcore to v0.42-dev 0093278#3532
lklimek wants to merge 2 commits intov3.1-devfrom
feat/bump-rust-dashcore-v0.42-dev

Conversation

@lklimek
Copy link
Copy Markdown
Contributor

@lklimek lklimek commented Apr 24, 2026

Issue being fixed or feature implemented

Refresh our dashpay/rust-dashcore pin to the latest v0.42-dev HEAD (37 commits ahead of the previous pin, 88e8a9aa). Keeps platform aligned with ongoing key-wallet / dash-spv work and picks up several SPV, key-wallet, and FFI fixes that other clients are already consuming.

What was done?

Workspace bump from rev = 88e8a9aa1eadce79c8177f757f6741f8a55a83f5 to rev = 0093278609a22fc53086bfef569b74bf10544982 for:

  • dashcore, dash-spv, dash-spv-ffi
  • key-wallet, key-wallet-ffi, key-wallet-manager
  • dashcore-rpc

Added dash-network (new standalone crate extracted from dashcore upstream in PR dashpay/rust-dashcore#679) to [workspace.dependencies], pinned to the same rev and required by rs-platform-wallet-ffi for FFINetwork (now behind the ffi feature of dash-network rather than re-exported from key-wallet-ffi).

Breaking changes from upstream that actually hit this codebase:

Other upstream refactors (FFIExtendedPriv/PubKey renames, new FFIError, AssetLockTx DIP-00X fix, Address<NetworkChecked> serde fix) did not surface in the platform build — those APIs aren't referenced here.

How Has This Been Tested?

  • cargo check --workspace --all-targets — pass
  • cargo test --workspace --no-run — all test binaries compile
  • cargo fmt --all --check — clean
  • cargo clippy --workspace --all-targets -- -D warnings — same pre-existing warnings as v3.1-dev HEAD in rs-platform-value / rs-platform-serialization; not introduced by this bump

The full runtime test suite (yarn test) needs a running local node and was not executed. Recommend running it before merge.

Breaking Changes

None for platform consumers. All API shifts are internal (workspace-local dependency rev + the three call-site adjustments listed above).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests — not applicable; pure dependency bump
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any — no platform-facing breaking changes
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Co-authored by Claudius the Magnificent AI Agent

Pull in 37 upstream commits from dashpay/rust-dashcore v0.42-dev,
including the dash-network crate extraction, WalletType WatchOnly
unit-variant refactor, and the removal of WalletInfoInterface's
get_spendable_utxos (moved to account level).

Breaking changes that hit the platform build:

- key-wallet: WatchOnly is now a unit variant (no more xpub payload).
  Updated the contact_requests.rs test helper accordingly.
- key-wallet: get_spendable_utxos dropped from WalletInfoInterface.
  Removed the matching impl on PlatformWalletInfo — no platform
  callers.
- key-wallet-ffi: FFINetwork is no longer re-exported; it now lives
  in the new dash-network crate under the "ffi" feature. Added
  dash-network as a workspace dep and repointed imports in
  rs-platform-wallet-ffi.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@lklimek has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: de439145-6ce5-4a0e-8856-c4ff21bcef54

📥 Commits

Reviewing files that changed from the base of the PR and between 2b657d8 and a7e3000.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • Cargo.toml
  • packages/rs-platform-wallet-ffi/Cargo.toml
  • packages/rs-platform-wallet-ffi/src/platform_wallet_info.rs
  • packages/rs-platform-wallet-ffi/tests/integration_tests.rs
  • packages/rs-platform-wallet/src/platform_wallet_info/contact_requests.rs
  • packages/rs-platform-wallet/src/platform_wallet_info/wallet_info_interface.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/bump-rust-dashcore-v0.42-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 24, 2026
@lklimek lklimek marked this pull request as ready for review April 24, 2026 08:35
@lklimek lklimek changed the title chore(deps): bump rust-dashcore to v0.42-dev HEAD build: bump rust-dashcore to v0.42-dev HEAD Apr 24, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 24, 2026

🔍 Review in progress — actively reviewing now (commit a7e3000)
Queue position: 2/18

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lklimek lklimek added the ready for final review Ready for the final review. If AI was involved in producing this PR, it has already had a reviewer. label Apr 24, 2026
@lklimek lklimek changed the title build: bump rust-dashcore to v0.42-dev HEAD build: bump rust-dashcore to v0.42-dev 00932786 Apr 24, 2026
@lklimek lklimek changed the title build: bump rust-dashcore to v0.42-dev 00932786 build: bump rust-dashcore to v0.42-dev 0093278 Apr 24, 2026
Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

I verified commit a7e300078e4bb2d53c4f0c8aada983cd7d3c4954 against the source and diff. The change removes only a two-line comment from the #[cfg(test)] helper create_dummy_wallet in packages/rs-platform-wallet/src/platform_wallet_info/contact_requests.rs; the executable code at line 486 is unchanged, and there are no consensus, correctness, or test-behavior implications.

Reviewed commit: a7e3000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for final review Ready for the final review. If AI was involved in producing this PR, it has already had a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants