Repository navigation
Conversation
Protocol version 14 (dashpay/platform#5350) stores unsigned integer index values in value order, so a grouped `count` by rating now returns keys "01".."05" instead of the sign-flipped "81".."85". dashrate looked up the old keys, so every per-star count read 0, the derived average was null, and every resource showed "No reviews yet" even though reviews exist. Decode the returned keys with `ratingFromKeyHex` instead of re-encoding expected ones. Masking off the top bit handles both the PV14 and pre-PV14 forms. Apply the same fix to dashrate-lite.html. Unit tests now feed literal network-format keys rather than stubs built with the app's own encoder, which is why the break went unnoticed. A new read-only e2e spec checks on live testnet, for both the app and the lite page, that the per-star distribution sums to the total review count. It fails against the previous code. Closes #119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Add example apps, walkthroughs, and presentation assets - Expand tutorials and add Platform diagnostics and research notes
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing