Skip to content

docs: v2 asset locks - automatic funding + bech32 addresses#182

Open
knst wants to merge 1 commit intodashpay:masterfrom
knst:dip-0027-bech32m
Open

docs: v2 asset locks - automatic funding + bech32 addresses#182
knst wants to merge 1 commit intodashpay:masterfrom
knst:dip-0027-bech32m

Conversation

@knst
Copy link
Copy Markdown
Collaborator

@knst knst commented Apr 21, 2026

Summary by CodeRabbit

  • Documentation
    • Added Asset Lock Transaction Version 2 specification enabling automatic credit assignment to Identities based on output keys.
    • Expanded valid credit output script formats for version 2 transactions.
    • Documented v24 hard fork activation supporting both Asset Lock Transaction versions 1 and 2.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@knst has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 36 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 36 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 269b8434-d0eb-45f6-9e38-6a0265ee7d94

📥 Commits

Reviewing files that changed from the base of the PR and between 87cb45c and 3ad9194.

📒 Files selected for processing (1)
  • dip-0027.md
📝 Walkthrough

Walkthrough

Updates the DIP-0027 specification to introduce version 2 Asset Lock transactions featuring automatic credit assignment. Defines supported scriptPubKey forms, specifies v24 hard fork activation, and establishes address-encoding requirements with reference to DIP-0018.

Changes

Cohort / File(s) Summary
DIP-0027 Specification Update
dip-0027.md
Added new subsection documenting version 2 Asset Lock transactions with automatic credit assignment. Defined version=2 scriptPubKey forms (P2PKH, P2SH), v24 hard fork activation scope, and address-encoding requirements referencing DIP-0018.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'bech32 addresses' but the actual changes focus on v2 asset locks with automatic credit assignment and P2PKH/P2SH support, with only an indirect reference to address encoding (DIP-0018) rather than bech32 implementation. Consider revising the title to accurately reflect the main changes: 'docs: v2 asset locks with automatic credit assignment' or similar, removing the misleading 'bech32 addresses' reference.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dip-0027.md`:
- Line 91: Update the DIP text to avoid ambiguity by replacing references to
"pubkey" with "pubkey hash" where appropriate: specifically clarify that in a
`version = 2` Asset Lock transaction each entry in `credit_outputs` MUST be
credited to the Identity matching the entry's pubkey hash (not a raw pubkey) or
script hash, and update any related wording that mentions `pubkey` to `pubkey
hash` to reflect P2PKH locking scripts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cca78d3d-d9e5-460f-861a-463449b01a03

📥 Commits

Reviewing files that changed from the base of the PR and between a4d46dd and 87cb45c.

📒 Files selected for processing (1)
  • dip-0027.md

Comment thread dip-0027.md Outdated
Comment thread dip-0027.md

#### Version 2: Automatic Credit Assignment

A `version = 2` Asset Lock transaction signals that each entry in `credit_outputs` MUST be automatically credited by Platform to the Identity matching the entry's public key hash or script hash, without an accompanying Identity Registration or Top-Up state transition.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is intended to allow sending directly to platform addresses, correct? The text mentions crediting to an identity, but platform addresses aren't linked to particular identities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants