docs: v2 asset locks - automatic funding + bech32 addresses#182
docs: v2 asset locks - automatic funding + bech32 addresses#182knst wants to merge 1 commit intodashpay:masterfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughUpdates the DIP-0027 specification to introduce version 2 Asset Lock transactions featuring automatic credit assignment. Defines supported scriptPubKey forms, specifies v24 hard fork activation, and establishes address-encoding requirements with reference to DIP-0018. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dip-0027.md`:
- Line 91: Update the DIP text to avoid ambiguity by replacing references to
"pubkey" with "pubkey hash" where appropriate: specifically clarify that in a
`version = 2` Asset Lock transaction each entry in `credit_outputs` MUST be
credited to the Identity matching the entry's pubkey hash (not a raw pubkey) or
script hash, and update any related wording that mentions `pubkey` to `pubkey
hash` to reflect P2PKH locking scripts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
||
| #### Version 2: Automatic Credit Assignment | ||
|
|
||
| A `version = 2` Asset Lock transaction signals that each entry in `credit_outputs` MUST be automatically credited by Platform to the Identity matching the entry's public key hash or script hash, without an accompanying Identity Registration or Top-Up state transition. |
There was a problem hiding this comment.
This update is intended to allow sending directly to platform addresses, correct? The text mentions crediting to an identity, but platform addresses aren't linked to particular identities.
Summary by CodeRabbit