Conversation
A fix went in to fix building with Musl but the logic was flawed. Instead of only checking __GLIBC__ on Linux or Hurd it checks this everywhere and __GLIBC__ has no relevance outside of Linux or Hurd. Check for __OpenBSD__ which does not have ifunc support. Check for PPC also __GLIBC__. From FreeBSD/ppc64.. iop_profile.c:1273:6: error: 'target_clones' attribute needs GLIBC (2.23 and newer) that exports hardware capability bits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fix went in to fix building with Musl but the logic was flawed.
Instead of only checking
__GLIBC__on Linux or Hurd it checks thiseverywhere and
__GLIBC__has no relevance outside of Linux or Hurd.Check for
__OpenBSD__which does not have ifunc support.Check for PPC also
__GLIBC__.From FreeBSD/ppc64..
Checklist
src/tests/integration/where the pixelpipe is touched, ordarktable-clias a headless smoke test._(), new preferences are registered indata/darktableconfig.xml.in.RELEASE_NOTES.mdentry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.Test instructions
Build on OpenBSD and it fails to build due to ifunc usage.
Build on FreeBSD/ppc64 (without the bogus
__GLIBC__check) and it fails to build with the error above.