fix(ui): hide the titlebar spacer toolbar in native full screen - #364
Merged
Merged
Conversation
Native full screen rendered the invisible spacer toolbar (which only exists to center the traffic lights on the sidebar header) as an opaque strip across the top of the window, covering the sidebar controls and the tab strip. Hide the toolbar on will-enter and restore it on will-exit so full screen keeps the windowed layout.
![darkestdarky-bot[bot]](https://avatars.githubusercontent.com/in/3783368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The diff hides the main window's spacer toolbar during native full screen to prevent an opaque strip from covering the sidebar header and tab strip. It hoists the toolbar identifier to a constant, installs notification observers for full-screen entry/exit, and applies the visibility rule at window configuration time for session restore. The change is confined to the toolbar visibility logic and includes a unit test. No security, data-loss, or performance issues are introduced.
Review coverage: 127/127 diff lines supplied. Partial input (truncated: standards). Inline comments are limited to fully visible, valid right-side hunks. Reviewed commit: 202cc94d14381ef655266318546f717eceb6eb0b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
When the main window goes into native full screen, macOS was drawing the app's invisible spacer toolbar as a solid opaque strip across the top, covering the sidebar header and tab strip. This fix hides that toolbar for the duration of full screen and brings it back when the window returns to windowed mode, so full screen keeps the same edge-to-edge layout as windowed.
Summary
mainWindowToolbarIdentifierconstant so it can be matched from outside the configuration function.AppDelegate.syncMainWindowToolbarVisibility(_:inFullScreen:), driven bywillEnterFullScreenNotification/willExitFullScreenNotificationobservers installed once at launch, plus an explicit check at window-configuration time to cover restoring a window that's already in full screen (session restore).Test Plan
testMainWindowSpacerToolbarHidesInFullScreenAndReturnsAftercovering: toolbar hides on full-screen entry, restores on exit, and a foreign (non-main) toolbar is left untouched.xcodebuild ... build(BUILD SUCCEEDED).