Adopt Pierre edit mode with session drafts - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<File edit>surfaceWhy
Editing a file previously depended on Strand's custom textarea projection and the buffer was lost when the file document unmounted. Pierre now provides a native edit mode, and users need to move around the app without being forced to save incomplete work.
Impact
File writes remain explicit through Save or
Mod+S, with the existing optimistic stale-write guard intact. Drafts live only for the current app session and are cleared after saving, discarding, deleting the file, or closing the repository. Historical revisions and unsupported file types remain read-only.Validation
pnpm --filter ./ui exec tsc --noEmitpnpm --filter strand-ui test— 53 files, 337 tests passedpnpm --filter strand-ui buildcargo build --no-default-features