fix(tools): DeriveDenyHashes creates its output dir before writing (unblocks DerivedSync) - #1652
Open
elhoim wants to merge 1 commit into
Open
fix(tools): DeriveDenyHashes creates its output dir before writing (unblocks DerivedSync)#1652elhoim wants to merge 1 commit into
elhoim wants to merge 1 commit into
Conversation
…nblocks DerivedSync)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DeriveDenyHashes.tswrites its output toskills/_LIFEOS/DENY_HASHES.jsonbut never ensures that directory exists. On any install whereskills/_LIFEOS/isn't present — a fresh clone, or an install where that private skill hasn't been laid down yet — the write throws:Because
DerivedSync.tsrunsDeriveDenyHashesas one of its derivation steps, that unhandled throw aborts the whole derived-sync pass, leaving later derivatives stale.Fix
Create the output directory before writing — one line, standard tool hygiene:
(
mkdirSyncadded to thenode:fsimport,dirnametonode:path.) The output is salted hashes only — no plaintext — so self-creating the directory changes nothing about what's written, it just stops the crash.Verified
bun run DerivedSync.tsexits 1 at theDeriveDenyHashesstep; downstream derivatives left unregenerated.DeriveDenyHashesself-creates its dir, writes the file, andDerivedSync.tscompletes cleanly (exit 0, 0 drift).