Skip to content

BF: Pin rabbitmq image to 4.2-management in test docker-compose#1841

Merged
yarikoptic-gitmate merged 1 commit intomasterfrom
bf-pin-rabbitmq
Apr 25, 2026
Merged

BF: Pin rabbitmq image to 4.2-management in test docker-compose#1841
yarikoptic-gitmate merged 1 commit intomasterfrom
bf-pin-rabbitmq

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

The dandiarchive test stack used the floating tag rabbitmq:management, which began resolving to RabbitMQ 4.3.0 on 2026-04-24. CI runs started to fail. Workaround -- pin to 4.2-management to restore the previously-green behavior.

Claude's unverified analytics:

RabbitMQ 4.3.0 no longer permits transient_nonexcl_queues by default, which celery/kombu still relies on. The celery container crash-looped, assets stayed in "Pending" validation, and all Linux test jobs failed (e.g. test_publish_and_manipulate, test_get_dandiset_published*) even on unchanged master commits.

The dandiarchive test stack used the floating tag `rabbitmq:management`,
which began resolving to RabbitMQ 4.3.0 on 2026-04-24. CI runs started to fail.
Workaround -- pin to 4.2-management to restore the previously-green behavior.

Claude's unverified analytics:

RabbitMQ 4.3.0 no longer permits `transient_nonexcl_queues` by default,
which celery/kombu still relies on. The celery container crash-looped, assets
stayed in "Pending" validation, and all Linux test jobs failed (e.g.
test_publish_and_manipulate, test_get_dandiset_published*) even on unchanged
master commits.

Co-Authored-By: Claude Code 2.1.120 / Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.27%. Comparing base (0af950f) to head (03ed80e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   76.28%   76.27%   -0.01%     
==========================================
  Files          87       87              
  Lines       12484    12484              
==========================================
- Hits         9523     9522       -1     
- Misses       2961     2962       +1     
Flag Coverage Δ
unittests 76.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Apr 25, 2026
@yarikoptic-gitmate yarikoptic-gitmate merged commit 4a14a1f into master Apr 25, 2026
37 of 39 checks passed
@yarikoptic-gitmate yarikoptic-gitmate deleted the bf-pin-rabbitmq branch April 25, 2026 11:59
@brianhelba
Copy link
Copy Markdown
Contributor

@yarikoptic Can you issue a release of the CLI as soon as possible? This breakage is preventing integration tests on dandi-api from passing too.

Note, this same issue is being fixed in dandi-api in dandi/dandi-archive#2792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants