Add Model Viewer - #2903
Merged
Merged
Conversation
A subsequent PR will land normal maps, at which point this toggle will make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model viewer changes:
GuiRotatingModelDebugView, a debug-only panel over the rotatingmodel view with light azimuth and elevation sliders and a
light-position marker.
the base model viewer on the GM screen; the model debug view is
reachable from the home screen in debug builds.
crowd the model.
flat 0.5 step.
Notes:
GuiRotatingModelDebugViewperforms a lot of rendering logic parts of which match other rendering pipelines in the code. Might be nice to de-duplicate it at some point, but because of the conditional rendering of various shaders, and the experimental nature of the debug model viewer, it felt ok to keep it as separate code. I'm open to alterations.Screen caps
start screen
Model debug view
Gm Screen