Conversation
Motivation: If mover redirect arrives at the door before reply to mover start message, or response to mover start get lost, door might fall into uninterruptable waiting state. In such situation, pool will detect a mover that has no client and will resend the redirect, which will be ignored by the door. Modification: On redirect message for a transfer without moverId door will resend `startMover` request. As startMover is idempotent operation, pool will re-send the moverId Result: NFS door recovery on lost moverId. Acked-by: Lennart Sack Target: master, 12.0, 11.2 Require-book: no Require-notes: yes (cherry picked from commit e035243) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
If mover redirect arrives at the door before reply to mover start message, or response to mover start get lost,
door might fall into uninterruptable waiting state. In such situation, pool will detect a mover that has no client and will resend the redirect, which will be ignored by the door.
Modification:
On redirect message for a transfer without moverId door will resend
startMoverrequest. As startMover is idempotent operation, pool will re-send the moverIdResult:
NFS door recovery on lost moverId.
Acked-by: Lennart Sack
Target: master, 12.0, 11.2
Require-book: no
Require-notes: yes
(cherry picked from commit e035243)