Repository navigation
feat(web): read shows and their calendar events from HappyView instead of PDSes - #255
Open
botandbang wants to merge 5 commits into
Open
botandbang wants to merge 5 commits into
botandbang wants to merge 5 commits into
Conversation
…d of PDSes HappyView now indexes community.lexicon.calendar.event, keeping only events by accounts that manage one of the root's projects, and re-reads managers' events once per record script version. The announce form, the changed-in-another-app marker, and the reads before a save or delete come from HappyView instead of the manager's PDS. The edit form carries the CIDs of the show and event it shows, and a save only lands on those: one that HappyView no longer serves is refused before anything is written, and the event and then the show are written with swapRecord on them, so a change made elsewhere asks the manager to reload. A new show stays one applyWrites, a delete removes the event and then the show, and saves and deletes wait for the event to be served too.
…vents # Conflicts: # apps/web/README.md # apps/web/src/lib/server/forms/project.ts # apps/web/src/routes/projects/[slug]/+page.server.ts
…vents # Conflicts: # apps/web/README.md
2 of 4 tasks
Coverage Report for apps/web
File Coverage
SizeCompared with main. KiB are 1,024 bytes.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bnb
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The show form, the "changed in another calendar app" marker and the reads before a show save or delete read the show and its
community.lexicon.calendar.eventfrom the manager's PDS. They now read HappyView.Added:
lua/community/lexicon/calendar/event.lua, which indexes calendar events by accounts that manage one of the root's projects. It checks the author rather than a show naming the event, so arrival order doesn't matterChanged:
swapRecordon those CIDs, so a change made elsewhere asks the manager to reload.applyWriteshas no per-record swap, so an edit is twoputRecords, event first; a new show stays oneapplyWrites, and a delete removes the event and then the showserver/http.tsHow it was tested
pnpm test:integration: the form reads from HappyView, an edit made by another app while the form is open is refused, and a race against the real PDS's swappnpm verifyandpnpm test:coverageChecklist
apps/locallibrary/CHANGELOG.mdhas a line under Unreleased, if people using it will noticedocs/and--helpstill say what the code does