Conversation
Configure the TCP keepalive timeout and interval in a way that matches our server side behaviour. opsbugs #2100
hownowstephen
approved these changes
Jul 28, 2021
While testing we found out that the TCP timeout on GCP loadbalancers is 360 sec. The 600 sec value refers to connections from the LB to backends.
# Conflicts: # customerio/client_base.py
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4de1192. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Configure the TCP keepalive timeout and interval in a way that matches
our server side behaviour.
Note
Medium Risk
Changes the HTTP connection adapter used for all HTTPS requests, which can alter socket behavior across platforms and affect connection pooling/proxy scenarios. Functional scope is small but touches low-level networking settings.
Overview
Adds TCP keepalive configuration to outbound HTTPS requests. The client now mounts a custom
TCPKeepAliveHTTPAdapterthat setssocket_options(includingSO_KEEPALIVEplus platform-specificTCP_KEEPIDLE/TCP_KEEPINTVL) with new defaultsTCP_KEEPALIVE_IDLE_TIMEOUT=300andTCP_KEEPALIVE_INTERVAL=60.Adds a unit test asserting the adapter’s pool manager is configured with these keepalive options while preserving
urllib3’sHTTPConnection.default_socket_options.Reviewed by Cursor Bugbot for commit 8b8c15c. Bugbot is set up for automated code reviews on this repo. Configure here.