XML declaration missing from output

[mjemmeson]

Hi,

The declaration line in the template does not appear in the output - is this deliberate?

thanks,
Michael

PS - you may want to add bugtracker to 'resources' in the META.yml for the module (unless you prefer rt.cpan.org?)

i.e.
resources:
repository: git://github.com/cursork/xml-binddata.git
bugtracker: https://github.com/cursork/xml-binddata/issues

[cursork]

I'd personally call that a bug. The ->bind method is meant to be DWIM - and I'd want it to preserve both that and the source encoding.

It might be an idea to use parse_node($xml->documentElement, $your_data) directly as you can then use whichever XML::LibXML method to output the string.

Note that this is a result of using C14N normalisation: http://www.w3.org/TR/xml-c14n#NoXMLDecl

I'd be tempted to move to a plain toString - per https://github.com/cursork/xml-binddata/compare/remove-c14n - as it preserves these things. I think C14N is an accident of copying from some existing code which wanted that (can't remember why - but I'd guess it's due to <foo></foo> versus <foo/>)

Re. the META.yml - the GitHub::Meta dzil plugin should sort this, but it is apparently misbehaved due to Net::SSLeay being build against the wrong openssl. Will be fixed on next release.

[willsheppard]

Example code for a workaround, based on what cursork says above:

my $xml = XML::LibXML->load_xml(string => $template);
XML::BindData::parse_node( $xml->documentElement, { foo => 'bar' });
print $xml->toString;

[pjlsergeant]

@mjemmeson @willsheppard is there a PR for this?

[mjemmeson]

@pjlsergeant no - I actually quite like writing docs so I'll create one with the example code.

Not looked at this for a while, will also see if possible to offer the alternative output (with declaration) without breaking the original behaviour (although no idea if anyone besides us is using this!)