Fix Salesforce MCP config to use env-based URL and client ID - #206
Open
ralflukner wants to merge 1 commit into
Open
Fix Salesforce MCP config to use env-based URL and client ID#206ralflukner wants to merge 1 commit into
ralflukner wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 625c5dc. Configure here.
| "url": "${SALESFORCE_MCP_URL}", | ||
| "auth": { | ||
| "CLIENT_ID": "${CLIENT_ID}", | ||
| "CLIENT_ID": "${SALESFORCE_CLIENT_ID}", |
There was a problem hiding this comment.
Client ID placeholder mismatch
High Severity · Logic Bug
mcp.json now interpolates ${SALESFORCE_CLIENT_ID}, but plugin.json still declares and requires CLIENT_ID, and the README still documents ${CLIENT_ID}. Sibling plugins keep those names aligned, so Configure values for the consumer key will not populate auth and Salesforce OAuth is likely to fail.
Reviewed by Cursor Bugbot for commit 625c5dc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Replaces hardcoded Salesforce MCP URL and CLIENT_ID with environment variables:
This keeps sandbox/prod configurable and avoids committing tenant-specific values.
Note
Low Risk
Config-only env var rename; callers must set
SALESFORCE_CLIENT_IDinstead ofCLIENT_ID.Overview
Updates the Salesforce MCP server auth block so
CLIENT_IDis resolved from${SALESFORCE_CLIENT_ID}instead of the generic${CLIENT_ID}, matching the namespaced env vars used forSALESFORCE_MCP_URLand avoiding collisions with other integrations that might useCLIENT_ID.Reviewed by Cursor Bugbot for commit 625c5dc. Bugbot is set up for automated code reviews on this repo. Configure here.