Skip to content

Fix Salesforce MCP config to use env-based URL and client ID - #206

Open
ralflukner wants to merge 1 commit into
cursor:mainfrom
ralflukner:fix/salesforce-mcp-env
Open

Fix Salesforce MCP config to use env-based URL and client ID#206
ralflukner wants to merge 1 commit into
cursor:mainfrom
ralflukner:fix/salesforce-mcp-env

Conversation

@ralflukner

@ralflukner ralflukner commented Aug 11, 2026

Copy link
Copy Markdown

Replaces hardcoded Salesforce MCP URL and CLIENT_ID with environment variables:

  • SALESFORCE_MCP_URL
  • SALESFORCE_CLIENT_ID

This keeps sandbox/prod configurable and avoids committing tenant-specific values.


Note

Low Risk
Config-only env var rename; callers must set SALESFORCE_CLIENT_ID instead of CLIENT_ID.

Overview
Updates the Salesforce MCP server auth block so CLIENT_ID is resolved from ${SALESFORCE_CLIENT_ID} instead of the generic ${CLIENT_ID}, matching the namespaced env vars used for SALESFORCE_MCP_URL and avoiding collisions with other integrations that might use CLIENT_ID.

Reviewed by Cursor Bugbot for commit 625c5dc. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 625c5dc. Configure here.

"url": "${SALESFORCE_MCP_URL}",
"auth": {
"CLIENT_ID": "${CLIENT_ID}",
"CLIENT_ID": "${SALESFORCE_CLIENT_ID}",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client ID placeholder mismatch

High Severity · Logic Bug

mcp.json now interpolates ${SALESFORCE_CLIENT_ID}, but plugin.json still declares and requires CLIENT_ID, and the README still documents ${CLIENT_ID}. Sibling plugins keep those names aligned, so Configure values for the consumer key will not populate auth and Salesforce OAuth is likely to fail.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 625c5dc. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant